This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 85bf40d:

@kentcdodds Could you elaborate why we have the separate node identifier? As far as I can tell travis is not deduplicating the matrix so you end up with two runs for node 15 (before its release we had two runs for node 14): https://travis-ci.org/github/testing-library/react-testing-library/builds/739343261. It makes more sense to me to remove the node entry and update the config once node 16 is released.

node was added in ea67b17

@kentcdodds Could you elaborate why we have the separate node identifier? As far as I can tell travis is not deduplicating the matrix so you end up with two runs for node 15 (before its release we had two runs for node 14): https://travis-ci.org/github/testing-library/react-testing-library/builds/739343261. It makes more sense to me to remove the node entry and update the config once node 16 is released.

node was added in ea67b17

@eps1lon it looks like @kentcdodds wrote in #808 (comment) that we can remove the separate node identifier.. So I guess you can go ahead and remove it :)

I thought we still wanted to test Node 15, but using 15 instead of node so the version doesn't change over time

I can do this all day 😬

Codecov Report

Merging #809 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #809   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          117       117           
  Branches        16        16           
=========================================
  Hits           117       117           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f54b5...85bf40d. Read the comment docs.

Looks ready to merge for me

🎉 This PR is included in version 11.1.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀